Merge pull request #944 from zapier/poc_safely_capture_cli_args_in_an…

…alytics PDE-5641: feat(core) capture CLI arguments in analytics safely
zapier · Jan 9, 2025 · 9080e9e · 9080e9e
2 parents 78bef2a + a01801e
commit 9080e9e
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/cli/src/utils/analytics.js b/packages/cli/src/utils/analytics.js
@@ -29,7 +29,7 @@ const recordAnalytics = async (command, isValidCommand, args, flags) => {
     return;
   }
   const argKeys = Object.keys(args);
-
+  const flagKeys = Object.keys(flags);
   const shouldRecordAnonymously = analyticsMode === ANALYTICS_MODES.anonymous;
 
   const integrationIDKey = argKeys.find(
@@ -50,10 +50,8 @@ const recordAnalytics = async (command, isValidCommand, args, flags) => {
     isValidCommand,
     numArgs: argKeys.length,
     appId: linkedAppId,
-    flags: {
-      ...flags,
-      ...(command === 'help' ? { helpCommand: argKeys[0] } : {}), // include the beginning of args so we know what they want help on
-    },
+    argsKeys: argKeys,
+    flagKeys: flagKeys,
     cliVersion: pkg.version,
     os: shouldRecordAnonymously ? undefined : process.platform,
   };