Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce number of wf run when pr are in draft mode #160

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Reduce number of wf run when pr are in draft mode #160

merged 7 commits into from
Feb 6, 2025

Conversation

chicco785
Copy link
Member

Description

Reduce number of wf run when pr are in draft mode

Changes Made

  • Run docker build only if PR is not draft
  • Run pr check only if PR is not draft

Related Issues

N/A

Checklist

  • I have used a PR title that is descriptive enough for a release note.
  • I have tested these changes locally.
  • I have added appropriate tests or updated existing tests.
  • I have tested these changes on a cluster [name of the cluster] / customer [name of the customer]
  • I have added appropriate documentation or updated existing documentation.

@chicco785
Copy link
Member Author

@MarcoPignati I would not extend this approach to tests.

@chicco785 chicco785 marked this pull request as ready for review February 1, 2025 12:41
@chicco785 chicco785 requested review from a team and MarcoPignati and removed request for a team February 1, 2025 12:41
@chicco785 chicco785 added the refactor This issue/PR relates to refactoring. label Feb 1, 2025
cosimomeli
cosimomeli approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@cosimomeli cosimomeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chicco785 chicco785 merged commit 4c8d66e into main Feb 6, 2025
10 checks passed
@chicco785 chicco785 deleted the run-wf-on-not-draft-pr branch February 6, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosimomeli cosimomeli cosimomeli approved these changes

@MarcoPignati MarcoPignati Awaiting requested review from MarcoPignati MarcoPignati was automatically assigned from zaphiro-technologies/ops

Assignees

@chicco785 chicco785

Labels
refactor This issue/PR relates to refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chicco785 @cosimomeli