Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing various typing issues #87

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

max-radin
Copy link
Contributor

Description

This pull request addresses two minor typing issues:

  • MatrixFactoryGate.controlled did not use the same parameter name as the controlled method of the Gate protocol.
  • One of the decomposition rules tried to access the num_control_qubits attributes of a gate without ensuring that the gate is of type ControlledGate.

Please verify that you have completed the following steps

  • I have self-reviewed my code.
  • I have included test cases validating introduced feature/fix.
  • I have updated documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4af3cdc) 95.08% compared to head (abefda2) 95.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          49       49           
  Lines        3135     3135           
=======================================
  Hits         2981     2981           
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@max-radin max-radin merged commit 30503fb into main Jan 29, 2024
6 checks passed
@max-radin max-radin deleted the max-radin/typing-improvements branch January 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants