Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift owned tmp #242

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Openshift owned tmp #242

merged 3 commits into from
Dec 14, 2023

Conversation

klml
Copy link
Contributor

@klml klml commented Dec 12, 2023

What this PR does / why we need it

remove initContainer (for openshift uid owned /tmp for attachments upload) and use customInit from #231 in examples

Verbosity

I am not sure if this verbosity 37b5a31 is appreciated, we can remove this as you like.

Checklist

  • Chart Version bumped, its not a functional, but documantary change
  • Upgrading instructions are documented in the zammad/README.md

@klml
Copy link
Contributor Author

klml commented Dec 12, 2023

✖︎ zammad => (version: "10.2.0", path: "zammad") > chart version not ok. Needs a version bump!

do you still want it to be just a change to the documentation, a version bump?

mgruner
mgruner previously approved these changes Dec 13, 2023
Copy link
Collaborator

@mgruner mgruner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @klml. Please also add a patchlevel version bump. Even this change probably changes the content of the published chart, so we should bump the version.

@mgruner mgruner self-assigned this Dec 13, 2023
@mgruner mgruner merged commit fe2d2fc into zammad:main Dec 14, 2023
10 checks passed
@mgruner
Copy link
Collaborator

mgruner commented Dec 14, 2023

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants