Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #234 - customInit: Can't find config setting #235

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Nov 21, 2023

Which issue this PR fixes

Special notes for your reviewer

  • The solution was basically to first execute postgresql-init, and only then zammad-init, which also needed the database envs to be able to run Rails commands.
  • toYaml seemed to break multiline statements, so I removed it - not entirely sure

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped

@mgruner mgruner requested a review from monotek November 21, 2023 14:29
@mgruner mgruner self-assigned this Nov 21, 2023
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder why zammad-init is not the last one anyway?
maybe elasticsearch init should be moved above too?

@mgruner
Copy link
Collaborator Author

mgruner commented Nov 22, 2023

i wonder why zammad-init is not the last one anyway? maybe elasticsearch init should be moved above too?

I believe the order makes sense now:

  • postgresql-init handles database installation and migration.
  • zammad-init handles application (pre)configuration. This might also affect the next step:
  • elasticsearch-init rebuilds the ES index.

From my pov this should work and is also kindof similar to how zammad-init works in zammad-docker-compose. Of course we can add a customInit also to elasticsearch-init later if it turns out to be required. Ok?

@monotek
Copy link
Member

monotek commented Nov 23, 2023

Or we're making it an own init step?
If zammad / custom init is importand for elasticsearch init might it there be a case where it's importand for postgres init too?

@mgruner
Copy link
Collaborator Author

mgruner commented Nov 23, 2023

For me the present proposal seems to be sufficient at this time. Of course, by mounting custom configMaps, everything can be overridden for special scenarios.

@mgruner
Copy link
Collaborator Author

mgruner commented Nov 23, 2023

We cannot run it before postgresql-init because this handles the seeding of the database, which is required to store Settings.

@mgruner mgruner merged commit db93f42 into main Nov 23, 2023
10 checks passed
@mgruner mgruner deleted the issue-234 branch November 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

customInit: Can't find config setting
2 participants