Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-init also /opt/zammad/storage #226

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

klml
Copy link
Contributor

@klml klml commented Nov 1, 2023

What this PR does / why we need it

After a restart zammad-0 -c elasticsearch-init had an error Read-only file system /opt/zammad/storage

E, [2023-09-20T04:04:01.548417#9-6180] ERROR -- : Unable to send Ticket.find(290).search_index_update_backend backend: #<Errno::EROFS: Read-only file system @ dir_s_mkdir - /opt/zammad/storage>

this was already suggested in #214, which introduced /opt/zammad/storage in all containers and all initContainers

But #214 was superseded by #215, which introduced /opt/zammad/storage only in all containers, but not in initContainers.

I am not sure if we need /opt/zammad/storage in all initContainers, but for sure in elasticsearch-init.

Which issue this PR fixes

Checklist

  • Chart Version bumped
  • Upgrading instructions are documented in the README.md

@mgruner
Copy link
Collaborator

mgruner commented Nov 3, 2023

@klml this looks awesome. Would you be so kind to rebase please, f41b98d should hopefully fix the failing chart linting checks.

I would also suggest to go a step further: in all places where /opt/zammad/var is mounted, /opt/zammad/storage should be mounted as well. This is to provide a consistent environment for Zammad containers.

@klml klml marked this pull request as draft November 6, 2023 08:07
@mgruner
Copy link
Collaborator

mgruner commented Nov 6, 2023

I would also suggest to go a step further: in all places where /opt/zammad/var is mounted, /opt/zammad/storage should be mounted as well. This is to provide a consistent environment for Zammad containers.

One small correction: it would not be needed for containers that don't run the Zammad stack, but only need /opt/zammad/var to check for the zammad.ready file which signals that the zammad-init container finished, like the zammad-nginx container. But I would add it to all other places which run the Zammad code.

@klml
Copy link
Contributor Author

klml commented Nov 6, 2023

We have 4 init containers (currently all without /opt/zammad/storage), we need it in for sure in elasticsearch-init.
We dont need it in zammad-init.

So only postgresql-init and zammad-volume-permissions is left. I am not sure if /opt/zammad/storage is needed there.

@klml klml force-pushed the elasticsearch-init-opt-zammad-storage branch from 06fd744 to 8691667 Compare November 6, 2023 09:49
@klml klml marked this pull request as ready for review November 6, 2023 09:49
@mgruner
Copy link
Collaborator

mgruner commented Nov 6, 2023

I have to correct myself. The postgresql-init container does run the Zammad stack, so it should also get /storage. And zammad-init does not run the stack right now, but I would still add it there for consistency reasons. Would you be able to add this? Otherwise, I can do a follow-up.

@klml
Copy link
Contributor Author

klml commented Nov 7, 2023

@mgruner now we have /opt/zammad/storage and and /opt/zammad/var in all containers, except zammad-volume-permissions.

@mgruner mgruner merged commit a36771c into zammad:main Nov 7, 2023
8 checks passed
@mgruner
Copy link
Collaborator

mgruner commented Nov 7, 2023

👏 thanks a lot @klml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to restart due elasticsearch-init container
2 participants