-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document using existing secrets for the subcharts #223
Conversation
@johanneskastl thanks for your proposal, this looks really nice. Can you please point me to the Helm/Kubernetes documentation that talks about |
This is not a helm or Kubernetes specific key. It is something that must be supported by the chart, in this case the subcharts: |
So that's why I didn't find it. Thanks! |
Please check out bitnami/charts#20545 for questions on what exactly needs to go into the elasticsearch secret. This is in addition to the question above, whether elasticsearch in Zammad actually uses the password... |
Would you be so kind to rebase please, f41b98d should hopefully fix the failing chart linting checks. |
186b473
to
8c5a37e
Compare
Done |
The elasticsearch credentials are saved into the Zammad database by the
In the regular zammad containers, the configuration is used straight from the database. It's not consistent with other parts of the system, but that's how it works at present. |
This does not look like an error I introduced? |
Certainly not. Not sure what's going on yet. |
Can you try again please? aa05fbb should fix the linter. |
…isting Kubernetes secret instead of specifying passwords in the values.yaml The example is using the secret and key names from the `secrets` section in the values.yaml
…g Kubernetes secret instead of specifying passwords in the values.yaml The example is using the secret and key names from the `secrets` section in the values.yaml
… existing Kubernetes secret
8c5a37e
to
a65fba9
Compare
Thanks again @johanneskastl |
What this PR does / why we need it
Using the
secrets:
section the user can use existing secrets with the zammad chart. But the credentials for the subcharts are still in plaintext in thevalues.yaml
file.This PR adds commented examples on how to configure the subcharts to use the existing secrets.
Which issue this PR fixes
None. It could have been part of #76 that fixes #73
Special notes for your reviewer
Authentication for the memcached subchart is currently not being used at all, it seems. So I did not document anything there.
I am a little fishy on the details regarding the elasticsearch subchart. Enabling the
secrets.elasticsearch.useExisting
value leads to the secret being mounted in the zammad pod. However I have not found the secret being used in the elasticsearch part at all. But: The elasticsearch section did not contain any credentials, so it might well be that the elasticsearch credential just isn't used at all?Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
Upgrading instructions are documented in the README.mdNot necessary, no code changes.