Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #527 - Changes for package installation #529

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Conversation

ralf401
Copy link
Contributor

@ralf401 ralf401 commented Sep 2, 2024

No description provided.

@ralf401 ralf401 self-assigned this Sep 2, 2024
@ralf401 ralf401 changed the title Fixes #527 - Changes for package installation WIP: Fixes #527 - Changes for package installation Sep 2, 2024
@ralf401 ralf401 linked an issue Sep 2, 2024 that may be closed by this pull request
@ralf401
Copy link
Contributor Author

ralf401 commented Sep 2, 2024

Hi @t-shehab & @byPARSE

I did some (smaller) changes for the install instructions. I left the Redis topic untouched, there is another issue for that which is on hold as we discussed.

I'll add you both as a reviewer. You can download the html-zip from here to review it locally on your machine.

Notes:

  • OpenSUSE Leap 15.6 already includes wget, so no need to mention additional packages to install
  • Added RHEL in tab titles
  • Note for installing Zammad before configuring Elasticsearch already present, see here.
  • Removed Firewall commands for OpenSUSE Same firewall as RedHat based distributions -> extended tab

@ralf401 ralf401 changed the title WIP: Fixes #527 - Changes for package installation Fixes #527 - Changes for package installation Sep 3, 2024
@ralf401 ralf401 requested review from t-shehab and byPARSE September 3, 2024 06:43
@t-shehab
Copy link
Contributor

t-shehab commented Sep 9, 2024

Apart from the comment I posted above, the changes look fine for me (without having tested all the commands, assuming you did).

I'd personally prefer a single note that root privileges are required, and then the commands be given without sudo. But that's a matter of opinion, I guess.

@ralf401 ralf401 merged commit f72ed12 into pre-release Sep 9, 2024
1 check passed
@ralf401 ralf401 deleted the rsc/fixes/527 branch September 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust OpenSUSE/CentOS install instructions
2 participants