fix: open_env mapsize type, elmdb_env_thread failure escape #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open_env mapsize was an int but needed to be a uint64_t if open_env fails with NULL during elmdb_env_thread, after local free a direct return is needed instead of a goto shutdown since the latter tried to use the value of elmdb_env which is NULL in this case causing a SEGV.
|
Hi, I'm not sure why the CI build on 17.4 fails, but it's good on the other OTP versions. Can this get merged? Dan |
|
Would very much like to see this merged. Just got burned by an overflowing max db size. Verified that the fix works on OTP 20. |
|
So it seems that the author have abandoned this project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_env mapsize was an int but needed to be a uint64_t
if open_env fails with NULL during elmdb_env_thread, after local
free a direct return is needed instead of a goto shutdown since the
latter tried to use the value of elmdb_env which is NULL in this case
causing a SEGV.