Path on windows platform #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URL double encoding in Chrome These changes fix the issue reported in zalando#394 The solution was to change the paths to be system independent. Tested in windows and unix platforms
Path on windows platform
invalid team IDThe team ID in your You can follow this guideline for help. |
1 similar comment
invalid team IDThe team ID in your You can follow this guideline for help. |
asaarilahti
previously approved these changes
Jul 24, 2024
|
Thanks for your contribution Gyuri! Would you be able to run |
|
Thanks for your email.
Just fixed and pushed the formatting as you requested.
Regards,
Gyuri
…On Wed, Jul 24, 2024 at 5:55 PM asaarilahti ***@***.***> wrote:
Thanks for your contribution Gyuri! Would you be able to run ./gradlew
:spotlessApply to make the formatting to pass the checks?
—
Reply to this email directly, view it on GitHub
<#440 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE3VXNHLJB4XP6V6BG6FLLZN657DAVCNFSM6AAAAABLMQVCH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBYGIZTAMZQGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
asaarilahti
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the issue reported in #394
The solution was to change the paths to be system independent.
Tested in windows and unix platforms