This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Thumbor variables #900
Merged
Thumbor variables #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreJunod
suggested changes
Dec 5, 2023
geocity/apps/api/views.py
Outdated
| @@ -521,12 +520,14 @@ def image_thumbor_display(request, submission_id, image_name): | |||
| thumbor_params += f"{width}x{height}/filters:format({format})" | |||
|
|
|||
| if settings.USE_THUMBOR: | |||
| print(settings.THUMBOR_SERVICE_URL) | |||
geocity/apps/api/views.py
Outdated
| ) | ||
| except requests.exceptions.RequestException as e: | ||
| response = requests.get(image_url) | ||
| print(e) |
| # Use this network to communicate with thumbor image resize service | ||
| # More information here: https://gitlab.com/geocity/thumbor-service | ||
| thumbor_network: | ||
| external: true |
There was a problem hiding this comment.
need name: ${ISOLATED_NETWORK_NAME} ?
There was a problem hiding this comment.
no, with this approach any geocity instance on the host can connect to the thumbor service on same host by attaching to the (pre-existing) thumbor_network
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.