feat: Add support for react router 7 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for react-router 7. Not sure it warrants a package name change, this could just be a major version update, since all the "remix" apps will need to be updated to react router 7 as the next phase of their lifecyle
|
@yusukebe Can you comment on any timeline/plans now that react-router 7 is out? Anecdotally, this is our project's only remix-* dependency (remix-auth, remix-utils, remix-development-tools, etc) which hasn't updated to be react-router v7 compatible |
|
@jfsiii I've been waiting for a while, but I think it's about time to switch. @barakcodes Can you resolve the conflict in this PR? I may change the project name and npm package name to |
|
Hi @barakcodes I updated your branch to resolve the conflicts. Looks good! I'll merge it and make it support React Router 7. I will deprecate supporting Remix v2 (to keep the implementation simple) and rename the package and the repo to |
This was referenced Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for react-router 7.
Not sure it warrants a package name change , this could just be a major version update, since all the "remix" apps will need to be updated to react router 7 as the next phase of their lifecycle
Apologies in advance for the large diff, it's mostly lock files.