Session/9 Unit tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuk1ch1
commented
May 16, 2024
yuk1ch1
commented
May 16, 2024
lib/presentation/screen/weather/weather_screen_state_controller.g.dart
Outdated
Show resolved
Hide resolved
|
Ready for review 🚀 |
|
Ready for review 🚀 |
morikann
reviewed
May 16, 2024
morikann
reviewed
May 20, 2024
morikann
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM です！
ハドルでもお話しさせていただきましたが、今回は @VisibleForTesting を使うところはなさそうです！
|
memo含めて、レビューありがとうございます🌻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題
close #10
対応箇所
*すみませんがエンコーディング、デコーディングのテストはスキップとさせてください
動作
ないので省略
レビューして欲しいところ
研修評価項目と比べてみて
@VisibleForTestingは自分は使ってなかったけど使ったほうがいい場所があれば教えていただきたいです🙏