Decimal format: support any decimal delimiter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decimals. (my french local uses commas instead of dots for DecimalFormat)
ghost
assigned
juanramirez
pushed a commit
to juanramirez/yuitest
that referenced
this pull request
Jul 10, 2013
Updated Java binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The french local uses commas instead of dots for decimal numbers.
The Coverage report fails badly :
Can't get property calledLinePercentageName using method get/isCalledLinePercentageName from com.yahoo.platform.yuitest.coverage.results.SummaryCoverageReport instance
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.antlr.stringtemplate.language.ASTExpr.invokeMethod(ASTExpr.java:564)
at org.antlr.stringtemplate.language.ASTExpr.rawGetObjectProperty(ASTExpr.java:515)
at org.antlr.stringtemplate.language.ASTExpr.getObjectProperty(ASTExpr.java:417)
at org.antlr.stringtemplate.language.ActionEvaluator.attribute(ActionEvaluator.java:351)
at org.antlr.stringtemplate.language.ActionEvaluator.expr(ActionEvaluator.java:136)
at org.antlr.stringtemplate.language.ActionEvaluator.action(ActionEvaluator.java:84)
at org.antlr.stringtemplate.language.ASTExpr.write(ASTExpr.java:149)
at org.antlr.stringtemplate.StringTemplate.write(StringTemplate.java:705)
at org.antlr.stringtemplate.StringTemplate.toString(StringTemplate.java:1670)
at org.antlr.stringtemplate.StringTemplate.toString(StringTemplate.java:1661)
at com.yahoo.platform.yuitest.writers.StringTemplateWriter.write(StringTemplateWriter.java:109)
at com.yahoo.platform.yuitest.coverage.report.LCOVReportGenerator.generateIndexPage(LCOVReportGenerator.java:164)
at com.yahoo.platform.yuitest.coverage.report.LCOVReportGenerator.generate(LCOVReportGenerator.java:76)
at com.yahoo.platform.yuitest.selenium.SessionResultFileGenerator.generateCoverageFiles(SessionResultFileGenerator.java:135)
at com.yahoo.platform.yuitest.selenium.SessionResultFileGenerator.generateAll(SessionResultFileGenerator.java:62)
at com.yahoo.platform.yuitest.selenium.YUITestSeleniumDriver.main(YUITestSeleniumDriver.java:195)
Caused by: java.lang.NumberFormatException: For input string: "37,5"
at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1224)
at java.lang.Double.valueOf(Double.java:475)
at com.yahoo.platform.yuitest.coverage.results.SummaryCoverageReport.getCalledLinePercentage(SummaryCoverageReport.java:196)
at com.yahoo.platform.yuitest.coverage.results.SummaryCoverageReport.getCalledLinePercentageName(SummaryCoverageReport.java:206)
... 20 more
My fix is not very nice but works : ericabouaf@6cce5cc