Implement AliasGlobalVariable Node locations

yui-knk · Sep 21, 2024 · dbf36f0 · dbf36f0
1 parent e8ae7f4
commit dbf36f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/ast_to_prism/parser.rb b/lib/ast_to_prism/parser.rb
@@ -2039,14 +2039,15 @@ def convert_node(node, block: nil)
         )
       when :VALIAS
         nd_alias, nd_orig = node.children
+        loc, keyword_loc = node.locations
 
         # (source, new_name, old_name, keyword_loc, location)
         Prism::AliasGlobalVariableNode.new(
           source,
           Prism::GlobalVariableReadNode.new(source, nd_alias, null_location),
           Prism::GlobalVariableReadNode.new(source, nd_orig, null_location),
-          null_location,
-          location(node)
+          location(keyword_loc),
+          location(loc),
         )
       when :UNDEF
         # TODO: Change original node structures

diff --git a/spec/basic_spec.rb b/spec/basic_spec.rb
@@ -2082,7 +2082,9 @@ def foo(a, b, opt1=1, opt2=2, *rest, y, z, kw: 1, **kwrest, &blk)
   end
 
   describe "valias" do
-    xit "tests" do
+    pending "Occur NoMethodError: undefined method '>>' for nil"
+
+    it "tests" do
       test_code("alias $y $x")
     end
   end