Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observedGeneration field to the YtsaurusStatus #333

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

wilwell
Copy link
Contributor

@wilwell wilwell commented Sep 6, 2024

To distinguish better between states of YtSaurus while updating we are adding observedGeneration to the YtsurusStatus, so if the Ytsaurus configuration is updated we could easily see it by increased observedGeneration.

This change resolves the issue #307.

@l0kix2 l0kix2 self-requested a review September 6, 2024 12:11
pkg/apiproxy/ytsaurus.go Outdated Show resolved Hide resolved
controllers/sync.go Outdated Show resolved Hide resolved
@wilwell wilwell requested a review from l0kix2 September 6, 2024 12:45
@l0kix2 l0kix2 changed the title Add observedGeneration field to the YtsurusStatus Add observedGeneration field to the YtsaurusStatus Sep 6, 2024
@l0kix2 l0kix2 merged commit 3ef2c6c into ytsaurus:main Sep 6, 2024
5 checks passed
@l0kix2
Copy link
Collaborator

l0kix2 commented Sep 11, 2024

Fix #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants