Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutating/defaulter webhooks #296

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

koct9i
Copy link
Collaborator

@koct9i koct9i commented Jun 26, 2024

No description provided.

@koct9i koct9i force-pushed the remove-defaulter-webhook branch 2 times, most recently from c11b756 to a474c70 Compare June 26, 2024 15:34
Copy link
Collaborator

@l0kix2 l0kix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will defaults be applied at all without hook?

api/v1/ytsaurus_webhook.go Show resolved Hide resolved
@koct9i koct9i force-pushed the remove-defaulter-webhook branch from a474c70 to bf89a60 Compare June 27, 2024 09:44
@koct9i koct9i force-pushed the remove-defaulter-webhook branch from bf89a60 to 019d49a Compare June 27, 2024 09:45
@koct9i
Copy link
Collaborator Author

koct9i commented Jun 27, 2024

Will defaults be applied at all without hook?

Yep. Defaults should be applied on read automatically.

https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#defaulting

@l0kix2 l0kix2 merged commit af4032b into ytsaurus:main Jun 27, 2024
5 checks passed
@koct9i koct9i deleted the remove-defaulter-webhook branch August 5, 2024 09:14
leo-astorsky pushed a commit to leo-astorsky/yt-k8s-operator that referenced this pull request Aug 13, 2024
@l0kix2 l0kix2 mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants