Add configuration for solomon exporter: specify host and some instance tags #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlobober
reviewed
May 6, 2024
Makefile
Outdated
| @@ -33,7 +33,7 @@ else | |||
| DOCKER_BUILD_ARGS += --build-arg VERSION="$(OPERATOR_TAG)" | |||
| endif | |||
| DOCKER_BUILD_ARGS += --build-arg REVISION="$(shell git rev-parse HEAD)" | |||
| DOCKER_BUILD_ARGS += --build-arg BUILD_DATE="$(shell date --rfc-3339=seconds)" | |||
| DOCKER_BUILD_ARGS += --build-arg BUILD_DATE="$(shell date -Iseconds)" | |||
There was a problem hiding this comment.
Let's move this to a separate PR.
There was a problem hiding this comment.
Ok, moved here: #260.
zlobober
reviewed
May 6, 2024
pkg/ytconfig/canondata/TestGetControllerAgentsConfig/test.canondata
Outdated
Show resolved
Hide resolved
zlobober
requested changes
May 6, 2024
achulkov2
force-pushed
the
solomon-exporter-config
branch
from
e2760b5 to
5ea87bf
Compare
l0kix2
approved these changes
May 17, 2024
|
LGTM, let's merge if @zlobober ok with the added test. |
zlobober
approved these changes
May 17, 2024
leo-astorsky
pushed a commit
to leo-astorsky/yt-k8s-operator
that referenced
this pull request
Aug 13, 2024
…e tags (ytsaurus#258) * Add configuration for solomon exporter: specify host and some instance tags * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the solomon_exporter section is not configured metrics are exported without any host-related labels, which isn't very convenient.
Tested locally that the sensors from
curl localhost:<monitoring_port>/solomon/allare now enriched with the added attributes.