UpdateSelector: add field #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0kix2
force-pushed
the
add_update_strategy_field
branch
4 times, most recently
from
cc59df9 to
3d8c084
Compare
l0kix2
force-pushed
the
add_update_strategy_field
branch
from
3d8c084 to
9bd180b
Compare
koct9i
approved these changes
Apr 19, 2024
| type UpdateStatus struct { | ||
| //+kubebuilder:default:=None | ||
| State UpdateState `json:"state,omitempty"` | ||
| Components []string `json:"components,omitempty"` | ||
| Flow UpdateFlow `json:"flow,omitempty"` |
There was a problem hiding this comment.
Please add comment that this field means - it goes into CRD and api.md
api/v1/ytsaurus_types.go
Outdated
| type UpdateSelector string | ||
|
|
||
| const ( | ||
| UpdateSelectorNone UpdateSelector = "" |
There was a problem hiding this comment.
"None" is confusing, especially when it is not "Nothing".
Maybe "Unspecified".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new
UpdateSelectorfield in spec which can be one of:-
""(empty) — field is not considered at all, which is backward compatible with usingEnableFullUpdate-
Nothing— no component can be updated (logs will indicate a reason)-
MasterOnly— only master will be updated (flow with safety checks/safe mode/snapshots/exit read only), other components' updates will be ignored-
TabletNodesOnly— only tablet nodes will be updated (with removing tablet bundles and recreating them after the update)-
ExecNodesOnly— only exec nodes will be updated (without extra steps, because it is stateless component)-
StatelessOnly— everything apart from master and tablet nodes will be updated (currently it is the same as so called local update flow)-
Everything— everything will be updated at once (currently it is the same as so called Full update flow)I've called the new field experimental since I'm not sure if we will want to support all that behaviours in the future after #115
Also
Flowfield is added toUpdateStatuswhich is persisted with transition to the Updating status. Usage can be seen in #239