labeller: make component labels more descrete #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koct9i
requested changes
Mar 25, 2024
kruftik
force-pushed
the
component-specific-label
branch
from
35ce5a0 to
8558e48
Compare
kruftik
changed the title
l0kix2
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Since those names of resources and labels are kinda part of our public API (some users might write scripts expecting them) and if we don't want to break it now or in the future it would be wise to first make a PR with test for this values. I think ComponentManager constructor should be split in two parts, where first one is about creating components and not interacting with k8s — so that constructor can be used in such test and we call GetMetaLabelMap for all components and canonize the result.
After that this PR will introduce change and we can be sure if nothing is broken and new changes are intended.
chizhonkova
added
wip
kruftik
force-pushed
the
component-specific-label
branch
from
8558e48 to
374c322
Compare
kruftik
force-pushed
the
component-specific-label
branch
from
2303234 to
01c315d
Compare
kruftik
force-pushed
the
component-specific-label
branch
from
1b14641 to
3336916
Compare
|
I guess this one also not actual now after labels refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.