Add diff for static config update case

ytsaurus · Nov 26, 2024 · b3e7432 · b3e7432
1 parent f02c865
commit b3e7432
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/pkg/components/config_helper.go b/pkg/components/config_helper.go
@@ -191,9 +191,16 @@ func (h *ConfigHelper) NeedReload() (bool, error) {
 		}
 		curConfig := h.getCurrentConfigValue(fileName)
 		if !cmp.Equal(curConfig, newConfig) {
-			h.apiProxy.RecordNormal(
-				"Reconciliation",
-				fmt.Sprintf("Config %s needs reload", fileName))
+			if curConfig == nil {
+				h.apiProxy.RecordNormal(
+					"Reconciliation",
+					fmt.Sprintf("Config %s needs creation", fileName))
+			} else {
+				configsDiff := cmp.Diff(string(curConfig), string(newConfig))
+				h.apiProxy.RecordNormal(
+					"Reconciliation",
+					fmt.Sprintf("Config %s needs reload. Diff: %s", fileName, configsDiff))
+			}
 			return true, nil
 		}
 	}