Errors resistance

yosiat · Jun 16, 2018 · d5581bd · d5581bd
1 parent b3d21d6
commit d5581bd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/Rakefile b/Rakefile
@@ -54,7 +54,13 @@ def run_benchmarks(files, items_count: 7_000)
 
     lines = run_process "ITEMS_COUNT=#{items_count} RAILS_ENV=production ruby #{benchmark_file}"
     rows = lines.map do |line|
-      row = JSON.parse(line)
+      begin
+        row = JSON.parse(line)
+      rescue JSON::ParserError
+        puts "> Failed parsing json"
+        puts lines.join
+        exit
+      end
       row.values
     end
 

diff --git a/benchmarks/type_casts/bm_active_record.rb b/benchmarks/type_casts/bm_active_record.rb
@@ -70,7 +70,6 @@ def db_ar_time
 ar_type_convert ActiveRecord::Type::Text, 1, "1"
 ar_type_convert ActiveRecord::Type::Integer, "1", 1
 ar_type_convert ActiveRecord::Type::Float, "1.23", 1.23
-ar_type_convert ActiveRecord::Type::Float, "Infinity", 0.0
 ar_type_convert ActiveRecord::Type::Boolean, "true", true
 ar_type_convert ActiveRecord::Type::Boolean, "t", true
 

diff --git a/benchmarks/type_casts/bm_panko.rb b/benchmarks/type_casts/bm_panko.rb
@@ -49,7 +49,6 @@ def db_panko_time
 panko_type_convert ActiveRecord::Type::Text, 1, "1"
 panko_type_convert ActiveRecord::Type::Integer, "1", 1
 panko_type_convert ActiveRecord::Type::Float, "1.23", 1.23
-panko_type_convert ActiveRecord::Type::Float, "Infinity", ::Float::INFINITY
 panko_type_convert ActiveRecord::Type::Boolean, "true", true
 panko_type_convert ActiveRecord::Type::Boolean, "t", true