Move from StandardRB to Rubocop

.github/workflows/lint.yml

@@ -26,7 +26,7 @@ jobs:
 
       - name: Lint ruby
         run: |
-          bundle exec rake standard
+          bundle exec rake rubocop
 
       - name: Lint C
         uses: jidicula/[email protected]

.rubocop.yml

@@ -1,29 +1,37 @@
-AllCops:
-  TargetRubyVersion: 2.5
-  DisplayCopNames: true
-  StyleGuideCopsOnly: false
+# We want Exclude directives from different
+# config files to get merged, not overwritten
+inherit_mode:
+  merge:
+    - Exclude
+
+require:
+  - standard
+  - rubocop-performance
+  - standard-performance
+  - rubocop-rspec
+
+inherit_gem:
+  standard: config/base.yml
+  standard-performance: config/base.yml
 
-Metrics/LineLength:
-  Max: 120
+AllCops:
+  TargetRubyVersion: 3.1
+  SuggestExtensions: false
+  NewCops: disable
+  Exclude:
+    - ext/**/*
+    - gemfiles/**/*
 
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
 
 Style/FrozenStringLiteralComment:
   Enabled: true
   EnforcedStyle: always
+  SafeAutoCorrect: true
 
-Layout/TrailingBlankLines:
-  Enabled: true
-
-Layout/TrailingWhitespace:
-  Enabled: true
+# TODO: need to work on specs.
+RSpec:
+  Enabled: false
 
-Style/FrozenStringLiteralComment:
-  Enabled: true
-
-Style/RedundantFreeze:
-  Enabled: true
-
-Performance/UnfreezeString:
-  Enabled: true
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - spec/**/*

Appraisals

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 appraise "7.0.0" do
   gem "sqlite3", "~> 1.4"
   gem "activesupport", "~> 7.0.0"

Gemfile

@@ -5,6 +5,8 @@ source "https://rubygems.org"
 gemspec
 
 group :benchmarks do
+  gem "vernier"
+  gem "stackprof"
   gem "pg"
 
   gem "benchmark-ips"
@@ -24,4 +26,11 @@ group :development do
   gem "rake-compiler"
 end
 
-gem "standard", group: [:development, :test]
+group :development, :test do
+  gem "rubocop"
+
+  gem "standard"
+  gem "standard-performance"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+end

Rakefile

@@ -6,7 +6,7 @@ require "json"
 require "terminal-table"
 require "rake/extensiontask"
 require "pty"
-require "standard/rake"
+require "rubocop/rake_task"
 
 gem = Gem::Specification.load(File.dirname(__FILE__) + "/panko_serializer.gemspec")
 
@@ -24,6 +24,8 @@ Rake::Task[:compile].prerequisites << :clean
 
 task default: :spec
 
+RuboCop::RakeTask.new
+
 def print_and_flush(str)
   print str
   $stdout.flush

benchmarks/allocs.rb

@@ -10,8 +10,8 @@ class PostFastSerializer < Panko::Serializer
   attributes :id, :body, :title, :author_id
 end
 
-def count_allocs(&block)
-  memory_report = MemoryProfiler.report(&block)
+def count_allocs(&)
+  memory_report = MemoryProfiler.report(&)
   puts memory_report.pretty_print
 end
 

benchmarks/bm_serialization_descriptor.rb

@@ -6,7 +6,7 @@
 require "panko_serializer"
 
 def generate_attributes(count)
-  (1..count).map { |i| "attr_#{i}".to_sym }
+  (1..count).map { |i| :"attr_#{i}" }
 end
 
 class LeafASerializer < Panko::Serializer

benchmarks/profile.rb

@@ -78,8 +78,8 @@ def request(method, path)
   response
 end
 
-def memory(&block)
-  mem = MemoryProfiler.report(&block)
+def memory(&)
+  mem = MemoryProfiler.report(&)
   mem.pretty_print
 end
 

gemfiles/7.0.0.gemfile

@@ -2,13 +2,14 @@
 
 source "https://rubygems.org"
 
-gem "standard", group: [:development, :test]
 gem "sqlite3", "~> 1.4"
 gem "activesupport", "~> 7.0.0"
 gem "activemodel", "~> 7.0.0"
 gem "activerecord", "~> 7.0.0", group: :test
 
 group :benchmarks do
+  gem "vernier"
+  gem "stackprof"
   gem "pg"
   gem "benchmark-ips"
   gem "active_model_serializers", "~> 0.10"
@@ -27,4 +28,12 @@ group :development do
   gem "rake-compiler"
 end
 
+group :development, :test do
+  gem "rubocop"
+  gem "standard"
+  gem "standard-performance"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+end
+
 gemspec path: "../"

gemfiles/7.0.0.gemfile.lock

@@ -119,8 +119,11 @@ GEM
     rubocop-performance (1.22.1)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (3.1.0)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     sqlite3 (1.7.3-arm64-darwin)
+    stackprof (0.2.26)
     standard (1.41.1)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
@@ -139,6 +142,7 @@ GEM
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.6.0)
+    vernier (1.2.1)
 
 PLATFORMS
   arm64-darwin-23
@@ -158,9 +162,15 @@ DEPENDENCIES
   rake
   rake-compiler
   rspec (~> 3.0)
+  rubocop
+  rubocop-performance
+  rubocop-rspec
   sqlite3 (~> 1.4)
+  stackprof
   standard
+  standard-performance
   terminal-table
+  vernier
 
 BUNDLED WITH
    2.4.6

gemfiles/7.1.0.gemfile

@@ -2,13 +2,14 @@
 
 source "https://rubygems.org"
 
-gem "standard", group: [:development, :test]
 gem "sqlite3", "~> 1.4"
 gem "activesupport", "~> 7.1.0"
 gem "activemodel", "~> 7.1.0"
 gem "activerecord", "~> 7.1.0", group: :test
 
 group :benchmarks do
+  gem "vernier"
+  gem "stackprof"
   gem "pg"
   gem "benchmark-ips"
   gem "active_model_serializers", "~> 0.10"
@@ -27,4 +28,12 @@ group :development do
   gem "rake-compiler"
 end
 
+group :development, :test do
+  gem "rubocop"
+  gem "standard"
+  gem "standard-performance"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+end
+
 gemspec path: "../"

gemfiles/7.1.0.gemfile.lock

@@ -134,8 +134,11 @@ GEM
     rubocop-performance (1.22.1)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (3.1.0)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     sqlite3 (1.7.3-arm64-darwin)
+    stackprof (0.2.26)
     standard (1.41.1)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
@@ -155,6 +158,7 @@ GEM
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.6.0)
+    vernier (1.2.1)
 
 PLATFORMS
   arm64-darwin-23
@@ -174,9 +178,15 @@ DEPENDENCIES
   rake
   rake-compiler
   rspec (~> 3.0)
+  rubocop
+  rubocop-performance
+  rubocop-rspec
   sqlite3 (~> 1.4)
+  stackprof
   standard
+  standard-performance
   terminal-table
+  vernier
 
 BUNDLED WITH
    2.4.6

gemfiles/7.2.0.gemfile

@@ -2,13 +2,14 @@
 
 source "https://rubygems.org"
 
-gem "standard", group: [:development, :test]
 gem "sqlite3", "~> 1.4"
 gem "activesupport", "~> 7.2.0"
 gem "activemodel", "~> 7.2.0"
 gem "activerecord", "~> 7.2.0", group: :test
 
 group :benchmarks do
+  gem "vernier"
+  gem "stackprof"
   gem "pg"
   gem "benchmark-ips"
   gem "active_model_serializers", "~> 0.10"
@@ -27,4 +28,12 @@ group :development do
   gem "rake-compiler"
 end
 
+group :development, :test do
+  gem "rubocop"
+  gem "standard"
+  gem "standard-performance"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+end
+
 gemspec path: "../"

gemfiles/7.2.0.gemfile.lock

@@ -136,9 +136,12 @@ GEM
     rubocop-performance (1.22.1)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
+    rubocop-rspec (3.1.0)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     securerandom (0.3.1)
     sqlite3 (1.7.3-arm64-darwin)
+    stackprof (0.2.26)
     standard (1.41.1)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.0)
@@ -159,6 +162,7 @@ GEM
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.6.0)
     useragent (0.16.10)
+    vernier (1.2.1)
 
 PLATFORMS
   arm64-darwin
@@ -178,9 +182,15 @@ DEPENDENCIES
   rake
   rake-compiler
   rspec (~> 3.0)
+  rubocop
+  rubocop-performance
+  rubocop-rspec
   sqlite3 (~> 1.4)
+  stackprof
   standard
+  standard-performance
   terminal-table
+  vernier
 
 BUNDLED WITH
    2.5.21

gemfiles/8.0.0.gemfile

@@ -2,13 +2,14 @@
 
 source "https://rubygems.org"
 
-gem "standard", group: [:development, :test]
 gem "sqlite3", ">= 2.1"
 gem "activesupport", "~> 8.0.0.rc1"
 gem "activemodel", "~> 8.0.0.rc1"
 gem "activerecord", "~> 8.0.0.rc1", group: :test
 
 group :benchmarks do
+  gem "vernier"
+  gem "stackprof"
   gem "pg"
   gem "benchmark-ips"
   gem "active_model_serializers", "~> 0.10"
@@ -27,4 +28,12 @@ group :development do
   gem "rake-compiler"
 end
 
+group :development, :test do
+  gem "rubocop"
+  gem "standard"
+  gem "standard-performance"
+  gem "rubocop-performance"
+  gem "rubocop-rspec"
+end
+
 gemspec path: "../"