Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: expose commit stats #349

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

spanner: expose commit stats #349

wants to merge 4 commits into from

Conversation

danielnorberg
Copy link
Contributor

@yoshidan yoshidan added the safe to test safe to test label Feb 4, 2025
@yoshidan
Copy link
Owner

yoshidan commented Feb 4, 2025

@danielnorberg Please fix the CI error.

  Compiling google-cloud-spanner v0.32.0 (/home/runner/work/google-cloud-rust/google-cloud-rust/spanner)
error[E0277]: the trait bound `std::option::Option<CommitResult>: From<CommitResponse>` is not satisfied
   --> spanner/src/client.rs:388:35
    |
388 |                     Ok(s) => Ok(s.into()),
    |                                   ^^^^ the trait `From<CommitResponse>` is not implemented for `std::option::Option<CommitResult>`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielnorberg @yoshidan