final touches on the LBCLASSIC-154 fix

yoorick · Dec 3, 2009 · 5f017a3 · 5f017a3
1 parent 5f3d8fa
commit 5f017a3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeFilter.java b/logback-classic/src/main/java/ch/qos/logback/classic/turbo/ReconfigureOnChangeFilter.java
@@ -26,6 +26,7 @@
 import ch.qos.logback.core.CoreConstants;
 import ch.qos.logback.core.joran.spi.JoranException;
 import ch.qos.logback.core.spi.FilterReply;
+import ch.qos.logback.core.status.InfoStatus;
 
 /**
  * Reconfigure a LoggerContext when the configuration file changes.
@@ -170,6 +171,8 @@ public void run() {
       } catch (JoranException e) {
         addError("Failure during reconfiguration", e);
       }
+      lc.getStatusManager().add(
+          new InfoStatus("done resetting the logging context", this));
     }
   }
 }
diff --git a/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigurePerf.java b/logback-classic/src/test/java/ch/qos/logback/classic/turbo/ReconfigurePerf.java
@@ -34,7 +34,7 @@
 import ch.qos.logback.core.testUtil.Env;
 
 public class ReconfigurePerf {
-  final static int THREAD_COUNT = 5;
+  final static int THREAD_COUNT = 50;
   final static int LOOP_LEN = 1000 * 1000;
 
   // the space in the file name mandated by

diff --git a/logback-site/src/site/pages/news.html b/logback-site/src/site/pages/news.html
@@ -94,6 +94,12 @@ <h3>13th of November 2009 - Release of version 0.9.18</h3>
     href="http://jira.qos.ch/browse/LBCLASSIC-102">LBCLASSIC-102</a>
     and as reported by Joern Huxhorn.</p>
 
+    <p>Fixed deadlock issue observed with appender which invoke
+    loggers as reported in <a
+    href="http://jira.qos.ch/browse/LBCLASSIC-154">LBCLASSIC-154</a>
+    by Andrew Perrine and debugged by Ralph Goers who also proposed
+    the relevant patch.</p>
+
     <hr width="80%" align="center" />
 
     <h3>9th of August 2009 - Release of version 0.9.17</h3>