Extra parser class to allow instance reuse, memory buffers reuse. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you benchmark this code? And yes, what is the performance gain compared with the trunk code? |
|
In my case it was used in DeviceHive server to reduce memory usage, garbage collection time, and finally have more CPU left for the application itself. But i'm not working with DH for a quite a long time now, thus probably would be good to close PR, as it looks like author deprecated library. |
|
Okay, fair enough. BTW, I do not think this lib is deprecated. It is updated quite recently. |
|
@rmuller i saw, however PR was not accepted, nor rejected. |
|
Closing as there is better PR with JMH #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.