Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the prefix v for the semantic version if necessary #1415

Closed
wants to merge 3 commits into from

Conversation

coffmark
Copy link

@coffmark coffmark commented Nov 7, 2023

Describe your changes

  • Remove the prefix v for the semantic version in SPM if necessary, as in v2.2.0.

Issue ticket number and link

  • None. (as far as I've seen)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests.

Thanks!

@coffmark coffmark changed the title Remove the v prefix if necessary Remove the prefix v for the semantic version if necessary Nov 8, 2023
@yonaskolb
Copy link
Owner

@coffmark can you help me understand the issue? How does SPM manage this when you reference a dependency with and without v when the tag contains a v?

@coffmark
Copy link
Author

Screenshot 2024-04-10 10 02 08

In SPM, it outputs an error when the tag contains a v.
I'm beginning to feel that my PR are not right.
Thank you for your comments 🙏

@coffmark coffmark closed this Apr 10, 2024
@coffmark coffmark deleted the feature/remove-v-prefix branch April 10, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants