Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use addScopeToCssLegacy to fix dict css on Kiwi due to out of date Chromium base #1809

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Feb 8, 2025

Only tested on Chromium. Need a tester for Kiwi.

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/ui-ux The issue or PR is related to UI/UX/Design labels Feb 8, 2025
@Kuuuube Kuuuube requested a review from a team as a code owner February 8, 2025 16:50
@Kuuuube
Copy link
Member Author

Kuuuube commented Feb 9, 2025

Got confirmation on discord that this fix works. https://discord.com/channels/1171709317343346789/1328462667731697684/1337960617725919283

Should be good to merge.

@Kuuuube Kuuuube added this pull request to the merge queue Feb 9, 2025
Merged via the queue into yomidevs:master with commit f3fdb69 Feb 9, 2025
25 checks passed
@Kuuuube Kuuuube deleted the fix-kiwi-css-scope-breaking branch February 9, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants