Python312 support #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitch
reviewed
Dec 22, 2024
| @@ -119,16 +119,17 @@ class OpenSRS(object): | |||
|
|
|||
| MSG_ALREADY_RENEWED_SANDBOX = 'Domain Already Renewed' | |||
|
|
|||
| def __init__(self, host, port, username, private_key, default_timeout): | |||
| def __init__(self, host, port, username, private_key, default_timeout, proxy=None): | |||
There was a problem hiding this comment.
E501 line too long (87 > 80 characters)
|
|
||
| def _get_channel(self): | ||
| return XCPChannel(self.host, self.port, self.username, | ||
| self.private_key, self.default_timeout) | ||
| self.private_key, self.default_timeout, proxy=self.proxy) |
There was a problem hiding this comment.
E128 continuation line under-indented for visual indent
| @@ -1,9 +1,9 @@ | |||
| import hashlib | |||
| import logging | |||
| try: | |||
| from urllib.request import urlopen, Request | |||
| from urllib.request import urlopen, Request, ProxyHandler, build_opener, install_opener | |||
There was a problem hiding this comment.
E501 line too long (91 > 80 characters)
| except ImportError: | ||
| from urllib2 import urlopen, Request | ||
| from urllib2 import urlopen, Request, ProxyHandler, build_opener, install_opener |
There was a problem hiding this comment.
E501 line too long (84 > 80 characters)
| @@ -128,23 +128,27 @@ def sign(self, private_key): | |||
|
|
|||
|
|
|||
| class XCPChannel(object): | |||
| def __init__(self, host, port, username, private_key, default_timeout): | |||
| def __init__(self, host, port, username, private_key, default_timeout, proxy=None): | |||
There was a problem hiding this comment.
E501 line too long (87 > 80 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.