Add phpstan to tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.4 just came out. Symfony 7.1 is current, but next week it will be 7.2.
|
This is very nice of you saying this, thank you 🙏 It is OK to start with small PhpStan level, you always have to pick an entry point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Yann, I ran across your bundle when looking for an example of how to configure CI for a Symfony bundle. Very clean.
I added phpstan, it's set at level 3 now. At level 4, it shows a warning, which I guess I should open in another issue.
Thanks for releasing this bundle, I'm learning a lot just by following your code and configuration.