Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused features, and simplify configuration structure #2

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

yann-eugone
Copy link
Contributor

Because it is unclear how the environment feature works, it has been dropped

Because the configuration structure is easier to understand/evolve, it has been flattened

@yann-eugone yann-eugone requested a review from J-Ben87 January 4, 2024 16:35
@codecov-commenter
Copy link

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (38c2c43) 0.00% compared to head (0dd6942) 0.00%.

Files Patch % Lines
src/DependencyInjection/Configuration.php 0.00% 37 Missing ⚠️
.../DependencyInjection/YokaiSafeCommandExtension.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master      #2   +/-   ##
========================================
  Coverage      0.00%   0.00%           
+ Complexity       26      11   -15     
========================================
  Files             4       3    -1     
  Lines           158     142   -16     
========================================
+ Misses          158     142   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yann-eugone yann-eugone requested a review from J-Ben87 January 5, 2024 07:57
@yann-eugone yann-eugone merged commit c9d68bc into master Jan 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants