Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP-899 Fix scroll issue on assign users modal #4520

Conversation

gabiayako
Copy link
Collaborator

@gabiayako gabiayako commented Feb 10, 2025

This PR addresses two issues occurring in both Dev and Prod environments, as demonstrated in the video below:

Screen.Recording.2025-02-10.at.09.43.29.mov
1.	The background scrolls down each time the assigned users’ suggestions list is clicked.
2.	The background remains scrollable when the modal is open.

Issue 1: Background scrolling when interacting with the suggestions list

The root cause appears to be the height of the assigned users’ list, which overflows the visible screen space and causes the background to shift. To mitigate this, the following changes were implemented:

  • The assigned users’ list was given a fixed height.
  • When the list is clicked, the modal automatically scrolls to the bottom, minimizing any unexpected shifts.

Issue 2: Background remains scrollable while the modal is open

To resolve this, I implemented a solution based on this Stack Overflow answer. This ensures the background becomes unscrollable when the modal is active, improving the overall user experience.


After the fix:

Screen.Recording.2025-02-10.at.09.51.37.mov

Although it's not perfect because there still a shift in the first click, it doesn't scroll each time the user clicks on the assigned users’ suggestions list.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (098ea6f) to head (77e4e8b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4520   +/-   ##
=======================================
  Coverage   99.49%   99.50%           
=======================================
  Files        1092     1092           
  Lines       22191    22206   +15     
  Branches     7031     7034    +3     
=======================================
+ Hits        22080    22095   +15     
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabiayako gabiayako merged commit 6af065e into master Feb 11, 2025
65 checks passed
@gabiayako gabiayako deleted the ASAP-899-fix-background-scroll-when-opening-users-suggestions branch February 11, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants