-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAP-899 Fix scroll issue on assign users modal #4520
Merged
gabiayako
merged 1 commit into
master
from
ASAP-899-fix-background-scroll-when-opening-users-suggestions
Feb 11, 2025
Merged
ASAP-899 Fix scroll issue on assign users modal #4520
gabiayako
merged 1 commit into
master
from
ASAP-899-fix-background-scroll-when-opening-users-suggestions
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4520 +/- ##
=======================================
Coverage 99.49% 99.50%
=======================================
Files 1092 1092
Lines 22191 22206 +15
Branches 7031 7034 +3
=======================================
+ Hits 22080 22095 +15
Misses 111 111 ☔ View full report in Codecov by Sentry. |
dianaguimaraes
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues occurring in both Dev and Prod environments, as demonstrated in the video below:
Screen.Recording.2025-02-10.at.09.43.29.mov
Issue 1: Background scrolling when interacting with the suggestions list
The root cause appears to be the height of the assigned users’ list, which overflows the visible screen space and causes the background to shift. To mitigate this, the following changes were implemented:
Issue 2: Background remains scrollable while the modal is open
To resolve this, I implemented a solution based on this Stack Overflow answer. This ensures the background becomes unscrollable when the modal is active, improving the overall user experience.
After the fix:
Screen.Recording.2025-02-10.at.09.51.37.mov
Although it's not perfect because there still a shift in the first click, it doesn't scroll each time the user clicks on the assigned users’ suggestions list.