Add OpenResty LuaJIT tests. #98
Conversation
|
Roughly how long do these take to run? |
third_party_tests/run.sh
Outdated
| # | ||
| # - meta_arith_jit.lua: | ||
| # | ||
| # thread '<unnamed>' panicked at ykrt/src/compile/jitc_yk/codegen/x64/lsregalloc.rs:815:22: |
There was a problem hiding this comment.
Huh. We should work out what's causing that, as that really shouldn't happen. Can we try minimising this one down?
There was a problem hiding this comment.
Sure. I can look at that today after your PRs are in. It may already be obsolete!
There was a problem hiding this comment.
That said, I don't mind getting this PR in (assuming the CI time isn't unreasonable), then fixing this in-tree.
There was a problem hiding this comment.
Sure, just measuring. Amusingly had to search for which package contains time to put in the dockerfile :)
Just over 2 minutes on b16. Note that this is yklua, which doesn't see much action anyway. |
|
Doh. You're right. |
|
Please force push an update which removes the comment about failing tests and reinstates those tests. When the latest yk PR has merged, I can then try this PR. |
|
Force pushed a fix. Can merge after ykjit/yk#1516 |
third_party_tests/run.sh
Outdated
| tnew_tdup.lua uclo.lua unordered_jit.lua unordered.lua vararg_jit.lua \ | ||
| wbarrier_jit.lua wbarrier.lua wbarrier_obar.lua xpcall_jit.lua" | ||
|
|
||
| # Reasons for skipping tests: |
There was a problem hiding this comment.
Please force push a fix which removes this comment.
There was a problem hiding this comment.
Oops! Fixed with force push.
https://github.com/openresty/luajit2-test-suite We run a subset of it. See comment in `run.sh` for which subset.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I wonder if we have to do something manual to increase Lua's stack? |
|
The test is checking that stack overflows are detected. https://github.com/openresty/luajit2-test-suite/blob/master/test/misc/stackov.lua |
|
Ah, I see the problem. Fixing. |
(plus some other tidy-ups)