Use -O2. #92
Merged
Use -O2. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the Lua tests and the benchmarks all now work with -O2, so we may aw well use it. As we learned the other week, a higher AOT optimisation level leads to smaller AOT IR, which in turn makes smaller JIT IR traces, which in theory we should be able to optimise better. Very quick benchmarking suggests this doesn't always speed us up yet. E.g. Richards ~9% speedup, BigLoop ~4% slowdown.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This can go in now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the Lua tests and the benchmarks all now work with -O2, so we may aw well use it.
As we learned the other week, a higher AOT optimisation level leads to smaller AOT IR, which in turn makes smaller JIT IR traces, which in theory we should be able to optimise better.
Very quick benchmarking suggests this doesn't always speed us up yet.
E.g. Richards ~9% speedup, BigLoop ~4% slowdown.