Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialise debug strings #223

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Serialise debug strings #223

merged 1 commit into from
Jan 22, 2025

Conversation

vext01
Copy link

@vext01 vext01 commented Jan 10, 2025

Required by ykjit/yk#1540

@ltratt
Copy link

ltratt commented Jan 10, 2025

Why "anchor"?

@vext01
Copy link
Author

vext01 commented Jan 13, 2025

Why "anchor"?

Because we will be using these to tie/map/anchor a place in the interpreter source code to a place in the JIT IR.

I thought yk_debug() or yk_debug_msg() was too generic, since we have all kinds of other debugging facilities in place throughout the system.

@ltratt
Copy link

ltratt commented Jan 13, 2025

I admit I'm bikeshedding, but found "anchor" a bit confusing. I wondered if yk_trace_str or yk_debug_str or something might be clearer?

@vext01
Copy link
Author

vext01 commented Jan 13, 2025

I was looking for a more specific term, but perhaps it's not worth worrying about.

If you are OK with yk_debug_str() I can use that.

@ltratt
Copy link

ltratt commented Jan 13, 2025

yk_debug_str works for me.

@vext01
Copy link
Author

vext01 commented Jan 16, 2025

Force pushed the renaming and synced to latest master.

@ltratt ltratt added this pull request to the merge queue Jan 16, 2025
@vext01 vext01 removed this pull request from the merge queue due to a manual request Jan 16, 2025
@vext01
Copy link
Author

vext01 commented Jan 16, 2025

Let's hold off on this until we've fixed outlined functions that contain debug strings.

@vext01 vext01 changed the title Serialise debug anchors. Serialise debug strings Jan 22, 2025
@vext01
Copy link
Author

vext01 commented Jan 22, 2025

This is ready to merge now.

@ltratt ltratt added this pull request to the merge queue Jan 22, 2025
Merged via the queue into ykjit:main with commit 5c65211 Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants