Small tweaks #17
Open
Small tweaks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want quick runs in overnight benchmarks.
When run from cron I was using an absolute path for the results dir, but then we were tacking `../..` onto it, which makes no sense. Rather than handle both cases, let's just say you have to use an absolute path.
ltratt
reviewed
Jan 10, 2025
| @@ -40,6 +40,12 @@ fi | |||
|
|
|||
| RES_DIR=$1; shift | |||
|
|
|||
| # To simplify path handling, require the results dir to be absolute. | |||
| if [ "$(realpath "${RES_DIR}")" != "${RES_DIR}" ]; then | |||
There was a problem hiding this comment.
Do the inner "s have any effect here?
There was a problem hiding this comment.
I think it allows paths to have spaces, but why would we? Shall we remove them?
There was a problem hiding this comment.
Yes, I would tend to remove them, because I'm very unsure what they do when nested. Out of curiosity, what does shellcheck say? It tends to be pretty good at these things. If it's happy with it, then I'm probably happy with it too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.