Merge pull request #140 from yjx0003/139-error-loading-course-names-w…

…ith-wrong-characters-in-the-file-system Fix #139
yjx0003 · Jul 26, 2024 · d66a1c0 · d66a1c0
2 parents 260bdff + 3393200
commit d66a1c0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/java/es/ubu/lsi/ubumonitor/util/UtilMethods.java b/src/main/java/es/ubu/lsi/ubumonitor/util/UtilMethods.java
@@ -154,8 +154,8 @@ public static <T> String joinWithQuotes(List<T> list) {
 	 * @param stringToRemove need to remove reserved character
 	 * @return without reserved character
 	 */
-	public static String removeReservedChar(String stringToRemove) {
-		String newString = stringToRemove.replaceAll(":|\\\\|/|\\?|\\*|\\|", "");
+	public static String removeReservedChar(String stringToRemove) {		
+		String newString = stringToRemove.replaceAll("\"|\\||<|>|:|\\\\|/|\\?|\\*|\\|", ""); // FIX #139 added more dangerous characters 
 		return newString.trim();
 
 	}

diff --git a/src/test/java/es/ubu/lsi/ubumonitor/UnitTest.java b/src/test/java/es/ubu/lsi/ubumonitor/UnitTest.java
@@ -57,6 +57,9 @@ public void removeBackSlashTest() {
 		fillMap(map, "Inglés EPS VENA-curso 2019:20", "Inglés EPS VENA-curso 201920");
 		fillMap(map, "Inglés EPS\\ VENA-curso 2019:20", "Inglés EPS VENA-curso 201920");
 		fillMap(map, "Inglés EPS ?VENA-curso 2019:20", "Inglés EPS VENA-curso 201920");
+		fillMap(map, "Inglés EPS \"VENA-curso 2019:20\"", "Inglés EPS VENA-curso 201920");
+		fillMap(map, "Inglés EPS <VENA-curso 2019:20>", "Inglés EPS VENA-curso 201920");
+		fillMap(map, "Inglés EPS |VENA-curso 2019:20|", "Inglés EPS VENA-curso 201920");
 		for (Map.Entry<String, String> entry : map.entrySet()) {
 			assertEquals(entry.getValue(), entry.getKey());
 		}