Debugger: minor refactoring and phpdoc
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Jan 21, 2025
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
xepozz
requested changes
Jan 22, 2025
src/Debugger.php
Outdated
| /** | ||
| * Stop debugger and collectors. Collected data isn't flushed to storage. | ||
| */ | ||
| public function terminate(): void |
There was a problem hiding this comment.
I'd suggest deactivate or disable. Terminate means that object would be accessible any longer
There was a problem hiding this comment.
The difference with shutdown is only about flushing data. Maybe pause is better here?
There was a problem hiding this comment.
By the way, should it be as public api?
Co-authored-by: Dmitriy Derepko <[email protected]>
Co-authored-by: Dmitriy Derepko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.