-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract getId / setId method from the MessageInterface to a new one #183
Conversation
xepozz
commented
Dec 25, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ✔️ |
Breaks BC? | ✔️ |
PR Summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
============================================
- Coverage 94.31% 94.25% -0.06%
- Complexity 340 346 +6
============================================
Files 40 41 +1
Lines 915 923 +8
============================================
+ Hits 863 870 +7
- Misses 52 53 +1 ☔ View full report in Codecov by Sentry. |
|
||
namespace Yiisoft\Yii\Queue\Message; | ||
|
||
interface ParametrizedMessageInterface extends MessageInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is a bit confusing. Parametrized means there are parameters. Here either there aren't or only one. Is there a better name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was temporary named, thought about moving also getMetadata
.
Is there a better name?
Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IdentifyableMessageInterface
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or MessageIdInterface
? :)
Also it might be closed after introducing envelope