Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use friendly exception #386

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Use friendly exception #386

merged 10 commits into from
Jan 21, 2025

Conversation

np25071984
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #324

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (56168c3) to head (777ce39).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##              master      #386   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       165       169    +4     
===========================================
  Files             11        11           
  Lines            480       492   +12     
===========================================
+ Hits             480       492   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@np25071984
Copy link
Contributor Author

Not sure if #234 and #324 are equal

np25071984
np25071984 commented Jan 12, 2025
View reviewed changes
samdark
samdark reviewed Jan 12, 2025
View reviewed changes
@samdark samdark requested a review from a team January 13, 2025 12:05
vjik
vjik requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildingException throws rarely. In most cases will be throwed NotFoundException. It needs to be made friendly.

samdark
samdark reviewed Jan 13, 2025
View reviewed changes
@samdark samdark requested a review from vjik January 14, 2025 07:54
@samdark
Copy link
Member

samdark commented Jan 14, 2025

👍

samdark
samdark reviewed Jan 14, 2025
View reviewed changes
@samdark
Copy link
Member

samdark commented Jan 14, 2025

Looks good to me now. @vjik ?

vjik
vjik approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also like to display build stack beautifully, but we can make it in future.

@samdark samdark merged commit 911dbb0 into yiisoft:master Jan 21, 2025
20 checks passed
@samdark
Copy link
Member

samdark commented Jan 21, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@np25071984 @samdark @vjik