better tests

yieldgate · Mar 9, 2022 · 2342eda · 2342eda
1 parent edada1b
commit 2342eda
Show file tree

Hide file tree

Showing 5 changed files with 357 additions and 23 deletions.
diff --git a/contracts/OffsetHelper.sol b/contracts/OffsetHelper.sol
@@ -154,8 +154,6 @@ contract OffsetHelper is OffsetHelperStorage {
         // Here is a link to the specific error from inside the safeTransferETH() method
         // https://github.com/sushiswap/sushiswap/blob/canary/contracts/uniswapv2/libraries/TransferHelper.sol#L27
 
-        // TODO also, the swap method will send unused MATIC to OffsetHelper instead of to the user, need to adapt for that
-
         // check eligibility of token to swap for
         require(isRedeemable(_toToken), "Can't swap for this token");
 
@@ -169,12 +167,9 @@ contract OffsetHelper is OffsetHelperStorage {
         path[2] = _toToken;
 
         // swap MATIC for tokens
-        routerSushi.swapETHForExactTokens{value: msg.value}(
-            _amount,
-            path,
-            address(this),
-            block.timestamp
-        );
+        uint256[] memory amounts = routerSushi.swapETHForExactTokens{
+            value: msg.value
+        }(_amount, path, address(this), block.timestamp);
 
         // update balances
         balances[msg.sender][path[2]] += _amount;

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -39,6 +39,7 @@
     "@openzeppelin/contracts": "^4.5.0",
     "@openzeppelin/contracts-upgradeable": "^4.5.1",
     "i": "^0.3.7",
-    "solc": "^0.8.12"
+    "solc": "^0.8.12",
+    "urql": "^2.2.0"
   }
 }