Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 64-bits integers (#7) #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

adrien-n
Copy link

This patch series functorizes the Simple module over integer handling in order to optionally support 64 bits integers. The API doesn't expose the functor but merely two modules: Simple and Simple64. The Simple module retains the same API while the Simple64 one use int64 instead of int where the values might overflow the range of int.

In addition to that, the tesuite is updated with a new test which is not in the "appendix-a.json" testuite, both Simple and Simple64 are tested, and dune is made to provide a diff against a reference output for improved readability.

@@ -0,0 +1,258 @@
I: running int tests from appendix_a.json, extra.json
I: total int tests = 83
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a git merge gone wrong?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. I've fixed it, thanks.

@adrien-n
Copy link
Author

I've updated my branch with the fix for the merge issues mentionned by @c-cube and a bad assert which checked > 0 instead of >= 0 for integers.

(and thanks @c-cube for the CI changes :) )

@ygrek ygrek mentioned this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants