Skip to content

Commit

Permalink
Target ES5 with the ESM build (#66)
Browse files Browse the repository at this point in the history
Target ES5 with the ESM build

This PR makes the ESM build compatible with IE11 so long as polyfills are present. Previously, the library would need to be transpiled to ES5 and have polyfills added.

J=SLAP-1074
TEST=manual

Set the core library target to ES5 and include this branch of the core. Remove babel from the build and add `import 'core/js'` to the testing library index. Confirm that the site works on IE11 and Chrome
  • Loading branch information
cea2aj authored Mar 4, 2021
1 parent 7acf448 commit ca87b28
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 0 additions & 1 deletion tsconfig.base.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"compilerOptions": {
"target": "es2015",
"strict": true,
"esModuleInterop": true,
"skipLibCheck": true,
Expand Down
1 change: 1 addition & 0 deletions tsconfig.cjs.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"extends": "./tsconfig.base.json",
"compilerOptions": {
"target": "es2015",
"module": "commonjs",
"outDir": "lib/commonjs"
}
Expand Down
1 change: 1 addition & 0 deletions tsconfig.esm.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"extends": "./tsconfig.base.json",
"compilerOptions": {
"target": "es5",
"module": "es6",
"outDir": "lib/esm"
}
Expand Down

0 comments on commit ca87b28

Please sign in to comment.