Skip to content

Commit

Permalink
fix compilation_check_for_test_site (#213)
Browse files Browse the repository at this point in the history
In a github workflow the `cd` command only affects the current step. This was causing false positives.
Also fix a casing issue with a test-site import on the js side.

J=NONE
TEST=manual

checked out a branch that should be failing, saw it fail locally, but succeed in the PR it's in
in the github workflow logs for the PR it's in, I see the regular search-core build being run twice,
and the test-site build not being run
  • Loading branch information
oshi97 authored Aug 16, 2022
1 parent b69f8e5 commit 97d69d2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
14 changes: 4 additions & 10 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,7 @@ jobs:
build_script: npm run build-ci

compilation_check_for_test_site:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js
uses: actions/setup-node@v3
- run: npm ci
- run: npm run build
- run: cd test-site
- run: npm i
- run: npm run build
uses: yext/slapshot-reusable-workflows/.github/workflows/run_tests.yml@v1
with:
test_script: cd test-site && npm i && npm run build
node_matrix: '["16.x"]'
2 changes: 1 addition & 1 deletion test-site/src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { provideCore } from '@yext/search-core';
import verticalRequest from './requests/verticalRequest';
import universalRequest from './requests/universalRequest';
import questionRequest from './requests/questionRequest';
import { univeralAutocompleteRequest, verticalAutocompleteRequest, filterSearchRequest } from './requests/autoCompleteRequests';
import { univeralAutocompleteRequest, verticalAutocompleteRequest, filterSearchRequest } from './requests/autocompleteRequests';

const coreConfig = {
apiKey: 'df4b24f4075800e5e9705090c54c6c13',
Expand Down

0 comments on commit 97d69d2

Please sign in to comment.