Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pages-components): unique key for address line separators #79

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

hbendev
Copy link
Contributor

@hbendev hbendev commented Jan 13, 2025

When multiple separators were used on the same line, the keys (,) were not unique. Eg. the following example resulted in warnings:

<Address
  address={address}
  lines={[
    ["line1", "line2"],
    ["city", ",", "region", ",", "postalCode"],
  ]}
/>;

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 46fb5b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…nsole

when multiple separators are used on a line
@mkilpatrick mkilpatrick merged commit a704b13 into yext:main Jan 13, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants