fix(pages-components): resolve nested-interactive WCAG issue #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when pinUrl is present this will fix existing accessibility "nested-interactive" issues that are present wherever a LocationMap component is rendered with a pinUrl supplied as a prop J=PC-268331 TEST=manual
|
Jeffrey-Rhoads17
changed the title
|
Yes, please! |
mkilpatrick
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make location map pin element a div instead of a button when pinUrl is present. this will fix existing WCAG nested-interactive issues that are currently present wherever a LocationMap component is rendered with a pinUrl supplied as a prop.
Example page where this happens: https://stores.cabelas.com/us/al/huntsville/7090-cabela-drive-nw.html
J=PC-268331
TEST=manual