Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pages-components): components/maps #62

Merged
merged 23 commits into from
Nov 15, 2024
Merged

refactor(pages-components): components/maps #62

merged 23 commits into from
Nov 15, 2024

Conversation

dgurland
Copy link
Contributor

convert maps to typescript

J=CR-3536

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fe66043

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mkilpatrick
mkilpatrick reviewed Oct 4, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/pages-components/src/map/coordinate.ts Outdated Show resolved Hide resolved
packages/pages-components/tsconfig.json Outdated Show resolved Hide resolved
@dgurland dgurland changed the title refactor(custom): components/maps refactor(pages-components): components/maps Oct 4, 2024
mkilpatrick
mkilpatrick reviewed Oct 4, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
packages/pages-components/package.json Outdated Show resolved Hide resolved
packages/pages-components/tsconfig.json Outdated Show resolved Hide resolved
packages/pages-components/src/map/providers/mapQuest.ts Outdated Show resolved Hide resolved
@dgurland dgurland force-pushed the CR-3536/doit branch 2 times, most recently from 800c72f to 3bf0ab5 Compare November 15, 2024 19:48
@briantstephan
fix: prevent TS error for link cta prop (#70)
01e1fc7 
* fix: prevent TS error for link cta prop

* add getLinkFromProps helper
dgurland and others added 18 commits November 15, 2024 16:57
@dgurland
refactor(pages-components): components/maps
d962b9d 
convert maps to typescript

J=CR-3536
@dgurland
linter error fixes
43f2616
@github-actions @dgurland
Automated linting/prettier update
6206122
@Jared-Hood @dgurland
chore: declare global type for mapboxgl
64b017d
@github-actions @dgurland
Automated linting/prettier update
aec62b8
@Jared-Hood @dgurland
refactor: move Baidu and Google CustomMarker class definitions back i…
7ae92fd 
…nto Pin constructors
@github-actions @dgurland
Automated linting/prettier update
9619b16
@dgurland
address coordinate class feedback
b8787e1
@github-actions @dgurland
Automated linting/prettier update
977aec6
@dgurland
update lock file
a2d0371
@github-actions @dgurland
Automated linting/prettier update
8aea560
@dgurland
remove function as a parameter type in Coordinate class
c102ff1
@github-actions @dgurland
Automated linting/prettier update
1604b53
@dgurland
fix linter error
e40d1c0
@dgurland
fix Coordinate test failure
8976d3a
@dgurland
lock file changes and PR feedback fixes
1a37cd9
@github-actions @dgurland
Automated linting/prettier update
9ab6ccf
@mkilpatrick @dgurland
attempt to fix playwright actions
325eec1
mkilpatrick
mkilpatrick previously approved these changes Nov 15, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@mkilpatrick mkilpatrick self-requested a review November 15, 2024 22:02
@mkilpatrick mkilpatrick dismissed their stale review November 15, 2024 22:03

Didn't mean to

@dgurland dgurland merged commit fe66043 into CR-3536/trunk Nov 15, 2024
13 checks passed
@dgurland dgurland deleted the CR-3536/doit branch November 15, 2024 22:22
@dgurland dgurland mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilpatrick mkilpatrick mkilpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgurland @mkilpatrick @briantstephan @Jared-Hood