fix(pages-components): link's href not obfuscated (#76)

* fix(pages-components): link's href not obfuscated * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
yext · Jan 7, 2025 · 8e102cc · 8e102cc
1 parent 09bf670
commit 8e102cc
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/...ok/snapshots/__snapshots__/components-hoursstatus--custom-template-override.png b/...ok/snapshots/__snapshots__/components-hoursstatus--custom-template-override.png
diff --git a/...storybook/snapshots/__snapshots__/components-hoursstatus--default-component.png b/...storybook/snapshots/__snapshots__/components-hoursstatus--default-component.png
diff --git a/...ook/snapshots/__snapshots__/components-hoursstatus--twenty-four-hours-clock.png b/...ook/snapshots/__snapshots__/components-hoursstatus--twenty-four-hours-clock.png
diff --git a/packages/pages-components/src/components/link/link.test.tsx b/packages/pages-components/src/components/link/link.test.tsx
@@ -27,6 +27,18 @@ describe("Link", () => {
   it("throws an error when cta link is not set", () => {
     expect(() => render(<Link cta={{} as CTA} />)).toThrowError();
   });
+
+  it("renders with obfuscated email when using cta link", () => {
+    render(<Link cta={{ link: "mailto:test.com" }} />);
+    const link = screen.getByRole("link");
+    expect(link.getAttribute("href")).toEqual("bWFpbHRvOnRlc3QuY29t");
+  });
+
+  it("renders with obfuscated email when using href", () => {
+    render(<Link href="mailto:test.com" />);
+    const link = screen.getByRole("link");
+    expect(link.getAttribute("href")).toEqual("bWFpbHRvOnRlc3QuY29t");
+  });
 });
 
 vi.mock("../../components/analytics", () => {
@@ -71,7 +83,5 @@ describe("Link Component Handles Analytics Failures", () => {
 
 // TODO: Add tests
 // Check target="_blank" present on newTab
-// Check obfuscated label
-// Check obfuscated href
 // Check children is label if present
 // Check fallback to link for label
diff --git a/packages/pages-components/src/components/link/link.tsx b/packages/pages-components/src/components/link/link.tsx
@@ -110,7 +110,7 @@ export const Link = forwardRef<HTMLAnchorElement, LinkProps>(
 
     // hydration warnings suppressed because they will show when the xYextDebug query param is used
     return (
-      <a {...attributes} {...rest} suppressHydrationWarning={true}>
+      <a {...rest} {...attributes} suppressHydrationWarning={true}>
         {children || link.label || renderedLink}
       </a>
     );