Update Image Formatter To Work With All Image Url Formats #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanu1
reviewed
Apr 23, 2024
nmanu1
reviewed
Apr 23, 2024
nmanu1
reviewed
Apr 24, 2024
…LeastAsLarge case
nmanu1
reviewed
Apr 25, 2024
nmanu1
reviewed
Apr 26, 2024
nmanu1
reviewed
Apr 26, 2024
nmanu1
reviewed
Apr 27, 2024
nmanu1
approved these changes
Apr 27, 2024
Merged
jesuyedavid
added a commit
that referenced
this pull request
May 9, 2024
### Changes - Updated the image formatter to return a fully dynamically-sized image instead of the closest thumbnail out of a fixed set (#1184)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the image handling to accommodate all image url formats before, during and after the image url change.
Related thread: https://yext.slack.com/archives/C0DA5HJCT/p1713445795909829
J=WAT-3980
TEST=auto, manual
Ran
npm run test.Manually copied my change to two answers experience (one in US and one in EU). Confirmed the images in both experiences loads fine in Live Preview.