-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use express instead of serve-handler for snapshots (#766)
This pr updates our tests to use express instead of serve-handler. serve (likely due to using serve-handler) currently has a bug where, if any redirects occur, it will lose any query params you had in the url. See: vercel/serve#643 On top of that, serve will automatically redirect urls like /index.html to just /, which breaks our iframe integration for universal. J=SLAP-1313 TEST=auto percy snapshots for universal on iframe are now corrected and show the correct query
- Loading branch information
Showing
5 changed files
with
11 additions
and
22 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters